Re: [Qemu-devel] [PATCH 07/10] qdev: move bulk of qdev-properties.c to qom/object.c

[Andreas Färber]

Am 23.05.2012 17:44, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  hw/qdev-properties.c  |  487 
> +++++--------------------------------------------
>  hw/qdev.c             |   47 +----
>  hw/qdev.h             |   87 ---------
>  include/qemu/object.h |   98 ++++++++++
>  qom/object.c          |  459 ++++++++++++++++++++++++++++++++++++++++++++++
>  5 files changed, 604 insertions(+), 574 deletions(-)

I'm not so fond of blowing up object.c with stuff that was originally in
its own file. Had you considered a new qom/object-properties.c?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg