Re: [Qemu-devel] [PATCH 0/4] ISCSI: Passthough updates

[Paolo Bonzini]

Il 26/05/2012 06:56, Ronnie Sahlberg ha scritto:
> Paolo, list
> 
> Please find a set of patches for iscsi.
> 
> 1, The recent change to the eventsystem in iscsi is racy. If the
> async connect of the socket takes longer than almost instant, the
> shortcircuit trying to write directly to the socket may try to do so
> before the socket is established. So we hcange the logic here and
> ONLY try the shortcircuit avoiding setting up POLLOUT if we have been
> fully logged in.
> 
> This avoids the race where we might crash if the socket is not yet
> connected.
> 
> 2, Swithc to using READCAPACITY10  for MMC devices. Only SBC devices
> support READCAPACITY16 so far.
> 
> 3, Switch to use READ10 for MMC devices instead of READ16. With this
> patch ISCSI and MMC devices now work correctly.
> 
> 4, If the device is a SMC device, then force the device to be sg. We
> dont support emulation as far as i know for SMV devices, so these
> device types would only work for sg or iscsi passthrough anyway. The
> reason we need to forcer sg is that since we can not READ from a SMC
> device, we need to shortcircuit  find_image_format()  before it tries
> to do the bdrv_pread() trying to guess what format the image is.
> 
> With this patch I have verified I can access and manage a media
> changer via iscsi-passthrough.

Applied 1-2 to scsi-next branch for 1.1, 3 for 1.2.

Paolo