[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without eff
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.1? v2] slirp: Avoid statements without effect on Big Endian host |
|
Date: |
Mon, 28 May 2012 13:00:05 +0100 |
On 28 May 2012 12:47, Jan Kiszka <address@hidden> wrote:
> On 2012-05-28 00:10, Peter Maydell wrote:
>> On 27 May 2012 17:42, Andreas Färber <address@hidden> wrote:
>>> +# if defined(__APPLE__)
>>> +# undef NTOHL
>>> +# undef NTOHS
>>> +# undef HTONL
>>> +# undef HTONS
>>> +# define NTOHL(d) do { } while (0)
>>> +# define NTOHS(d) do { } while (0)
>>> +# define HTONL(d) do { } while (0)
>>> +# define HTONS(d) do { } while (0)
>>> +# else
>>
>> We could just use this for everything, not just if __APPLE__,
>> right? For big-endian the semantics we want are always "do
>> nothing" so it's always OK to undef and redefine...
>> That would save having a special case.
>
> Yes, please.
It occurred to me that you could also have the unconditional
#undefs outside the #ifdef HOST_WORDS_BIGENDIAN, but that
is starting to stray outside of the "simple fix for 1.1"
territory.
-- PMM