Re: [Qemu-devel] [PATCH] TCG: Fix TB invalidation after breakpoint insertion/deletion

[Avi Kivity]

On 05/28/2012 02:54 PM, Max Filippov wrote:
>>>
>>> Right. If the fix is going to be checked in then TeLeMan's original version
>>> with '|' is preferable for this reason.
>>
>> I disagree.  Whatever we call cpu_get_phys_page_debug() has to either
>> mask out the low bits, or not (I prefer the latter, since it's
>> unambiguous for large pages), but it has to be consistent.  Once it's
>> consistent, there's no reason to use clever tricks.
> 
> I meant a one line fix for the 1.1. I suspect that fixing entire
> cpu_get_phys_page_debug thing for 1.1 is too risky.
> 

Agree for 1.1.


-- 
error compiling committee.c: too many arguments to function