[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH 1.1?] qemu_rearm_alarm_timer: do not call rearm if the next deadline is INT64_MAX |
Date: |
Tue, 29 May 2012 19:13:10 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Tue, 29 May 2012, Stefan Weil wrote:
> Yes, we could set the upper limit to LONG_MAX seconds for some
> timers, but I did not want to have a dependency of the
> upper limit on sizeof(long). The function win32_rearm_timer
> only allows 4294967 seconds. Is there any reason why we
> should allow timers which expire after more than 11 days
> (1000000 seconds are about 11 days)? If there is none,
> 1000000 seconds would be a good upper limit for most timers
> (maybe also for Darwin). mm_rearm_timer is the only timer
> which then still needs its own upper limit.
If 1000000 works for Darwin, then I think it is a good idea.