Re: [Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

[Alexander Graf]

On 30.05.2012, at 13:22, Andreas Färber wrote:

> Am 30.05.2012 10:13, schrieb Alexander Graf:
>> 
>> On 21.05.2012, at 18:11, Fabien Chouteau wrote:
>> 
>>> The size of EPN field in MAS2 depends on page size. This patch adds a
>>> mask to discard invalid bits in EPN field.
>>> 
>>> Definition of EPN field from e500v2 RM:
>>> EPN Effective page number: Depending on page size, only the bits
>>> associated with a page boundary are valid. Bits that represent offsets
>>> within a page are ignored and should be cleared.
>>> 
>>> There is a similar (but more complicated) definition in PowerISA V2.06.
>>> 
>>> Signed-off-by: Fabien Chouteau <address@hidden>
>> 
>> No reply from Blue, so I applied this patch to ppc-next :). Thanks a lot!
> 
> I did reply though, so I'm not okay. Please rebase on top of the patches
> that I have supplied you with. Rebasing that set is no fun.

Of course it's no fun, but it's neither crucial nor are you Blue. I'm wary 
enough with a big change like this, but your mail didn't sound like you were 
100% confident that you took everything into account :(.

I'd really prefer to have Blue just resend a set that converts the target and 
be done with it. Unless you're 100% sure that you did everything correctly. 
Then please resend the whole patch set with your own SOB lines and declare your 
own ownership (or blameship rather) ;).


Alex