qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info


From: Luiz Capitulino
Subject: Re: [Qemu-devel] [PATCH v2] hmp/qxl: info spice: add qxl info
Date: Wed, 30 May 2012 10:16:58 -0300

On Wed, 30 May 2012 11:54:11 +0300
Alon Levy <address@hidden> wrote:

> On Tue, May 29, 2012 at 01:44:35PM -0300, Luiz Capitulino wrote:
> > On Tue, 29 May 2012 17:51:50 +0300
> > Alon Levy <address@hidden> wrote:
> > 
> > > On Tue, May 29, 2012 at 10:38:20AM -0300, Luiz Capitulino wrote:
> > > > On Tue, 29 May 2012 09:25:40 +0200
> > > > Gerd Hoffmann <address@hidden> wrote:
> > > > 
> > > > >   Hi,
> > > > > 
> > > > > >> How would that work? I have QXLInfo that only makes sense when the
> > > > > >> information is about a qxl device. Can't have opaque data in a QMP
> > > > > >> response, so would this be a "info display qxl" "info display 
> > > > > >> cirrus"
> > > > > >> etc. or "info qxl"?
> > > > > > 
> > > > > > You could show what's available and/or being used currently.
> > > > > 
> > > > > I think (Alon, correct me if I'm wrong) the use case is being able to
> > > > > figure whenever the guest drivers are installed and active.
> > > > 
> > > > Alon, can you confirm this? I'm still not clear on the use-case.
> > > > 
> > > > The two points I'm wondering are 1. If this is really tied to spice 
> > > > (and thus
> > > > this info should be part of query-spice) and now 2. if the use case 
> > > > above
> > > > really pertains to QMP.
> > > > 
> > > > I've talked to someone in the past about having a way to get 
> > > > information about
> > > > guest drivers statuses and the conclusion was that the guest-agent 
> > > > agent was
> > > > better suited for that.
> > > 
> > > The information I'm suggesting to expose is state of the guest as seen
> > > from device pov:
> > 
> > Do you expect mngt apps to use that info or is it just for debugging? If 
> > it's
> > the latter, then maybe we could add query-qxl as gen=no and declare it 
> > unstable.
> 
> It's for debugging. I don't expect management to use it, but I do expect
> it to be useful when someone comes with a problem to the list, as it's
> easy to retrieve information.
> 
> Where do I add "gen=no", how do you want me to mark this unstable? The
> point is to have this available, not to have this disabled. It's low
> risk, it's only displayed when someone does "info spice" (or "info virt"
> if someone would say that is preferable) or the equivalent QMP command.

It will be available. You can do the following:

 1. Add a query-qxl command, but that command should be in the experimental
    name space, this means that you should call it
    __org.qemu.experimental.query-qxl. Let's forget about gen=no for the
    moment.

    Also, don't forget to mention in the schema entry for the command that
    it's experimental and unstable.

  2. You have two options for HMP, either you add 'info qxl' or you
     extend 'info spice'. Your choice.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]