[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache |
|
Date: |
Thu, 31 May 2012 15:06:12 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Il 31/05/2012 14:33, Paolo Bonzini ha scritto:
>>>> >> > case 0x02: /* write cache enable */
>>>> >> > + bdrv_set_enable_write_cache(s->bs, true);
>>>> >> > + identify_data = (uint16_t *)s->identify_data;
>>>> >> > + put_le16(identify_data + 85, (1 << 14) | (1 << 5) | 1);
>> > How about just s->identify_set = 0; instead, so that all IDENTIFY logic
>> > stays together in one place?
>> >
> Good idea.
Hmm, this is a rat's nest because of the other patching we do for "set
transfer mode". I'd prefer to refactor it later.
Paolo
- Re: [Qemu-devel] [PATCH 1.2 3/7] block: always open protocol in writeback mode, (continued)
[Qemu-devel] [PATCH 1.2 4/7] block: copy enable_write_cache in bdrv_append, Paolo Bonzini, 2012/05/22
[Qemu-devel] [PATCH 1.2 5/7] block: add bdrv_set_enable_write_cache, Paolo Bonzini, 2012/05/22
[Qemu-devel] [PATCH 1.2 7/7] qcow2: always operate caches in writeback mode, Paolo Bonzini, 2012/05/22
[Qemu-devel] [PATCH 1.2 6/7] ide: support enable/disable write cache, Paolo Bonzini, 2012/05/22