Re: [Qemu-devel] [PATCH, v3] qemu/xendisk: set maximum number of grants to be used

[Jan Beulich]

>>> On 31.05.12 at 13:27, Stefano Stabellini <address@hidden>
wrote:
> On Thu, 31 May 2012, Jan Beulich wrote:
>> Legacy (non-pvops) gntdev drivers may require this to be done when the
>> number of grants intended to be used simultaneously exceeds a certain
>> driver specific default limit.
>> 
>> Change in v2: Double the number requested, as we need to account for
>> the allocations needing to happen in contiguous chunks. The worst case
>> number would be max_req * max_seg + (max_req - 1) * (max_seg - 1) + 1,
>> but in order to keep things simple just use 2 * max_req * max_seg.
>> 
>> Change in v3: introduce MAX_GRANTS(), and add a comment explaining its
>> definition.
>> 
>> Signed-off-by: Jan Beulich <address@hidden>
> 
> I think it is OK, I'll submit it as a bug fix for QEMU 1.1.

Thanks!

> It should be applied to qemu-xen-traditional too.

And the other one ("qemu/xendisk: properly update stats in
ioreq_release()") probably too.

Jan