qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Revert "rtl8139: do the network/host communicat


From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH] Revert "rtl8139: do the network/host communication only in normal operating mode"
Date: Mon, 04 Jun 2012 13:58:01 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120210 Thunderbird/10.0.1

On 06/04/2012 01:48 PM, Anthony Liguori wrote:
On 05/10/2012 04:37 PM, Jason Wang wrote:
This reverts commit ff71f2e8cacefae99179993204172bc65e4303df. This is because the linux 8139cp driver would leave the card in "Config Register Write Enable" mode after the eeprom were read or write ( which is unexpected in the spec ). Also a physical 8139 card can still DMA into host memory in modes other than
Normal mode, so we need revert this commit to align with the behavior of
physical card.

The issue of 8139cp driver should be fixed in linux seperately.

Signed-off-by: Jason Wang<address@hidden>

Applied.  Thanks.

Regards,

Anthony Liguori

Hi Anthony:

Michael has some concern on this patch, so I post another patch of validating the rx buf instead of checking the opmode, please see http://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02385.html. So maybe we can apply that or I need to send another patch on top of this reverting?

Thanks




reply via email to

[Prev in Thread] Current Thread [Next in Thread]