[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging |
|
Date: |
Mon, 04 Jun 2012 11:36:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Am 03.06.2012 19:38, schrieb Blue Swirl:
> Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF
> (for implemented cases) or to use LOG_UNIMP (unimplemented).
>
> Signed-off-by: Blue Swirl <address@hidden>
I would suggest that you check the messages of those cases that became
FLOPPY_DPRINTF(). Originally the macro printed "FLOPPY ERROR: " and now
it's not even mentioned any more that it is an error message, making
messages like "writing sector %d" totally misleading.
If you fix that up:
Acked-by: Kevin Wolf <address@hidden>