[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] fdc: floppy drive should be visible afte
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] fdc: floppy drive should be visible after start without media |
Date: |
Tue, 05 Jun 2012 08:23:53 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Marcelo Tosatti <address@hidden> writes:
> On Thu, May 24, 2012 at 11:02:28AM +0200, Pavel Hrdina wrote:
>> If you start guest with floppy drive but without media inserted, guest
>> still should see floppy drive pressent.
>>
>> Signed-off-by: Pavel Hrdina <address@hidden>
>> ---
>> hw/pc.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index 4d34a33..967c17a 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -382,7 +382,7 @@ void pc_cmos_init(ram_addr_t ram_size, ram_addr_t
>> above_4g_mem_size,
>> if (floppy) {
>> fdc_get_bs(fd, floppy);
>> for (i = 0; i < 2; i++) {
>> - if (fd[i] && bdrv_is_inserted(fd[i])) {
>> + if (fd[i]) {
>> bdrv_get_floppy_geometry_hint(fd[i], &nb_heads, &max_track,
>> &last_sect, FDRIVE_DRV_NONE,
>> &fd_type[i], &rate);
>> --
>
> This commit breaks WinXP.32 installation. It crashes during early setup
> stage, without a floppy disk specified.
>
> Specifying a floppy disk with -fda fixes the problem.
Backtrace?