[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 18/29] qemu-option: qemu_opts_validate(): use error_
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 18/29] qemu-option: qemu_opts_validate(): use error_set() |
Date: |
Tue, 5 Jun 2012 14:24:57 -0300 |
net_client_init() propagates the error up by calling qerror_report_err(),
because its users expect QError semantics.
Signed-off-by: Luiz Capitulino <address@hidden>
Reviewed-By: Laszlo Ersek <address@hidden>
---
net.c | 6 +++++-
qemu-option.c | 13 +++++--------
qemu-option.h | 2 +-
3 files changed, 11 insertions(+), 10 deletions(-)
diff --git a/net.c b/net.c
index 1922d8a..f5d9cc7 100644
--- a/net.c
+++ b/net.c
@@ -1136,10 +1136,14 @@ int net_client_init(Monitor *mon, QemuOpts *opts, int
is_netdev)
for (i = 0; i < NET_CLIENT_TYPE_MAX; i++) {
if (net_client_types[i].type != NULL &&
!strcmp(net_client_types[i].type, type)) {
+ Error *local_err = NULL;
VLANState *vlan = NULL;
int ret;
- if (qemu_opts_validate(opts, &net_client_types[i].desc[0]) == -1) {
+ qemu_opts_validate(opts, &net_client_types[i].desc[0], &local_err);
+ if (error_is_set(&local_err)) {
+ qerror_report_err(local_err);
+ error_free(local_err);
return -1;
}
diff --git a/qemu-option.c b/qemu-option.c
index 6d36970..eee3b45 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -1041,7 +1041,7 @@ QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict)
/* Validate parsed opts against descriptions where no
* descriptions were provided in the QemuOptsList.
*/
-int qemu_opts_validate(QemuOpts *opts, const QemuOptDesc *desc)
+void qemu_opts_validate(QemuOpts *opts, const QemuOptDesc *desc, Error **errp)
{
QemuOpt *opt;
Error *local_err = NULL;
@@ -1057,21 +1057,18 @@ int qemu_opts_validate(QemuOpts *opts, const
QemuOptDesc *desc)
}
}
if (desc[i].name == NULL) {
- qerror_report(QERR_INVALID_PARAMETER, opt->name);
- return -1;
+ error_set(errp, QERR_INVALID_PARAMETER, opt->name);
+ return;
}
opt->desc = &desc[i];
qemu_opt_parse(opt, &local_err);
if (error_is_set(&local_err)) {
- qerror_report_err(local_err);
- error_free(local_err);
- return -1;
+ error_propagate(errp, local_err);
+ return;
}
}
-
- return 0;
}
int qemu_opts_foreach(QemuOptsList *list, qemu_opts_loopfunc func, void
*opaque,
diff --git a/qemu-option.h b/qemu-option.h
index 4d5b3d3..e9fbbb5 100644
--- a/qemu-option.h
+++ b/qemu-option.h
@@ -125,7 +125,7 @@ int qemu_opts_set(QemuOptsList *list, const char *id,
const char *name, const char *value);
const char *qemu_opts_id(QemuOpts *opts);
void qemu_opts_del(QemuOpts *opts);
-int qemu_opts_validate(QemuOpts *opts, const QemuOptDesc *desc);
+void qemu_opts_validate(QemuOpts *opts, const QemuOptDesc *desc, Error **errp);
int qemu_opts_do_parse(QemuOpts *opts, const char *params, const char
*firstname);
QemuOpts *qemu_opts_parse(QemuOptsList *list, const char *params, int
permit_abbrev);
void qemu_opts_set_defaults(QemuOptsList *list, const char *params,
--
1.7.10.2.565.gbd578b5
- [Qemu-devel] [PATCH 02/29] Add API to check whether a physical address is I/O address, (continued)
- [Qemu-devel] [PATCH 02/29] Add API to check whether a physical address is I/O address, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 03/29] implement cpu_get_memory_mapping(), Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 05/29] Add API to get memory mapping, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 04/29] Add API to check whether paging mode is enabled, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 06/29] Add API to get memory mapping without do paging, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 09/29] target-i386: add API to get dump info, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 08/29] target-i386: Add API to write cpu status to core file, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 07/29] target-i386: Add API to write elf notes to core file, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 11/29] make gdb_id() generally avialable and rename it to cpu_index(), Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 10/29] target-i386: Add API to get note's size, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 18/29] qemu-option: qemu_opts_validate(): use error_set(),
Luiz Capitulino <=
- [Qemu-devel] [PATCH 16/29] qemu-option: parse_option_size(): use error_set(), Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 20/29] qemu-option: introduce qemu_opt_set_err(), Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 25/29] net: purge the monitor object from all init functions, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 22/29] qerror: introduce QERR_INVALID_OPTION_GROUP, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 24/29] qemu-config: introduce qemu_find_opts_err(), Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 29/29] Add 'query-events' command to QMP to query async events, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 28/29] qapi: convert netdev_del, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 27/29] qapi: convert netdev_add, Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 15/29] qemu-option: parse_option_bool(): use error_set(), Luiz Capitulino, 2012/06/05
- [Qemu-devel] [PATCH 23/29] qemu-config: find_list(): use error_set(), Luiz Capitulino, 2012/06/05