[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 5/7] block: always open drivers in writeback mode
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH v3 5/7] block: always open drivers in writeback mode |
Date: |
Wed, 6 Jun 2012 00:04:53 +0200 |
Formats are entirely in charge of flushes for metadata writes. For
guest-initiated writes, a writethrough cache is faked in the block layer.
So we can always open in writeback mode.
Signed-off-by: Paolo Bonzini <address@hidden>
---
block.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index e4396a6..48528fd 100644
--- a/block.c
+++ b/block.c
@@ -649,12 +649,13 @@ static int bdrv_open_common(BlockDriverState *bs, const
char *filename,
bs->opaque = g_malloc0(drv->instance_size);
bs->enable_write_cache = !!(flags & BDRV_O_CACHE_WB);
+ open_flags = flags | BDRV_O_CACHE_WB;
/*
* Clear flags that are internal to the block layer before opening the
* image.
*/
- open_flags = flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
+ open_flags &= ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
/*
* Snapshots should be writable.
--
1.7.10.1
- [Qemu-devel] [PATCH v3 0/7] Manual writethrough cache and cache mode toggle, Paolo Bonzini, 2012/06/05
- [Qemu-devel] [PATCH v3 1/7] block: flush in writethrough mode after writes, Paolo Bonzini, 2012/06/05
- [Qemu-devel] [PATCH v3 2/7] savevm: flush after saving vm state, Paolo Bonzini, 2012/06/05
- [Qemu-devel] [PATCH v3 3/7] block: copy enable_write_cache in bdrv_append, Paolo Bonzini, 2012/06/05
- [Qemu-devel] [PATCH v3 4/7] block: add bdrv_set_enable_write_cache, Paolo Bonzini, 2012/06/05
- [Qemu-devel] [PATCH v3 5/7] block: always open drivers in writeback mode,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v3 6/7] ide: support enable/disable write cache, Paolo Bonzini, 2012/06/05
- [Qemu-devel] [PATCH v3 7/7] qcow2: always operate caches in writeback mode, Paolo Bonzini, 2012/06/05
- Re: [Qemu-devel] [PATCH v3 0/7] Manual writethrough cache and cache mode toggle, Stefan Hajnoczi, 2012/06/08
- Re: [Qemu-devel] [PATCH v3 0/7] Manual writethrough cache and cache mode toggle, Stefan Hajnoczi, 2012/06/08