qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 16/17] qidl: add qidl-generated vmstate fields f


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH 16/17] qidl: add qidl-generated vmstate fields for rtc
Date: Wed, 06 Jun 2012 10:47:31 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1

On 06/06/2012 02:38 AM, Anthony Liguori wrote:
> On 06/05/2012 06:26 PM, Avi Kivity wrote:
>> On 06/05/2012 04:00 AM, Michael Roth wrote:
>>> Initial check-in of the qidl-generated vmstate fields for rtc.
>>>
>>
>> Don't, please.
> 
> As Mike said in another note, we want to keep the device schema in the
> tree so we can determine when it changes in 'make check' and complain
> loudly.
> 
> But I think we need a better way to do this.  Something like a 'make
> schema-update' target that will regenerate schemas and prepare them for
> checkin.

Yes, that's much better.  Also would be good to pretty-print them so
that incremental changes are easy to spot using 'diff'.

-- 
error compiling committee.c: too many arguments to function



reply via email to

[Prev in Thread] Current Thread [Next in Thread]