Re: [Qemu-devel] [PATCH 2/2] xen: Don't peek behind the BlockDriverState abstraction

[Peter Maydell]

On 5 June 2012 13:51, Markus Armbruster <address@hidden> wrote:
> @@ -554,6 +553,7 @@ static int blk_init(struct XenDevice *xendev)
>  {
>     struct XenBlkDev *blkdev = container_of(xendev, struct XenBlkDev, xendev);
>     int index, qflags, info = 0;
> +    char fmt_name[128];

Fixed length array with a hardcoded magic number size ?
If the block layer guarantees that format names are going to be
less than 128 bytes it ought to provide a suitable #define for
people to set array sizes to...

-- PMM