[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at co
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time |
Date: |
Wed, 06 Jun 2012 21:21:49 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 06/06/2012 09:15 PM, Anthony Liguori wrote:
> On 06/06/2012 08:16 PM, Paolo Bonzini wrote:
>> Il 06/06/2012 14:03, Peter Maydell ha scritto:
>>> Can we use
>>> mkdir -p "$(dirname "$2")"
>>>
>>> or are we still trying to be compatible with some non-POSIX
>>> shell from the dawn of time?
>>
>> Looks like we can, there are other occurrences of $() in configure.
>
> I saw that too, but I thought $() was a bash-ism.
$() is required by POSIX. The problem is that Solaris' /bin/sh does not
understand $(), since it is not a POSIX shell.
If you take care to sanitize shell execution into a sane shell (yes, it
is possible to write configure scripts that re-execute themselves under
a better shell than /bin/sh), then using $() can be one of the decision
points on whether a better shell has been found.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 01/25] build: remove trace-nested-y, (continued)
- [Qemu-devel] [PATCH v2 01/25] build: remove trace-nested-y, Paolo Bonzini, 2012/06/06
- [Qemu-devel] [PATCH v2 23/25] build: limit usage of vpath, Paolo Bonzini, 2012/06/06
- [Qemu-devel] [PATCH v2 24/25] build: compile oslib-obj-y once, Paolo Bonzini, 2012/06/06
- [Qemu-devel] [PATCH v2 22/25] build: libcacard Makefile cleanups, Paolo Bonzini, 2012/06/06
- [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Paolo Bonzini, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Anthony Liguori, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Paolo Bonzini, 2012/06/07
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Anthony Liguori, 2012/06/07
[Qemu-devel] [PATCH v2 09/25] build: put qom/ rules in a Makefile.objs file, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 21/25] build: move device tree to per-target Makefile, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 04/25] build: move *-user/ objects to nested Makefile.objs, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 19/25] build: convert libhw to nested Makefile.objs, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 08/25] build: move rules for nesting to Makefile.objs, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 03/25] build: add rules for nesting, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 13/25] build: move ui/ objects to nested Makefile.objs, Paolo Bonzini, 2012/06/06