[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at co
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time |
Date: |
Thu, 07 Jun 2012 07:26:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Il 07/06/2012 05:16, Anthony Liguori ha scritto:
> On 06/06/2012 07:54 PM, Paolo Bonzini wrote:
>>> From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001
>>> From: Anthony Liguori<address@hidden>
>>> Date: Wed, 6 Jun 2012 16:57:00 +0800
>>> Subject: [PATCH] configure: ensure directory exists when creating
>>> symlink
>>>
>>> Signed-off-by: Anthony Liguori<address@hidden>
>>> ---
>>> configure | 3 +--
>>> 1 files changed, 1 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index 07e3ff1..4a7f027 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -42,6 +42,7 @@ compile_prog() {
>>> # symbolically link $1 to $2. Portable version of "ln -sf".
>>> symlink() {
>>> rm -rf "$2"
>>> + mkdir -p `dirname $2`
>>
>> Please leave the argument quoted, like
>>
>> dir=`dirname "$2`
>> mkdir -p "$dir"
>>
>> Otherwise looks good. Do we need a v3? This can just be committed
>> before 25/25 or even before all my patches, and that would be just what
>> I send.
>
> Unfortunately, this conflicts pretty badly with Andreas' QOM CPU
> series. Could you rebase and send out a v3?
No, it's the dumping series from Luiz. I'll send a v3 as a pull request.
Paolo
- [Qemu-devel] [PATCH v2 24/25] build: compile oslib-obj-y once, (continued)
- [Qemu-devel] [PATCH v2 24/25] build: compile oslib-obj-y once, Paolo Bonzini, 2012/06/06
- [Qemu-devel] [PATCH v2 22/25] build: libcacard Makefile cleanups, Paolo Bonzini, 2012/06/06
- [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Paolo Bonzini, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Anthony Liguori, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Paolo Bonzini, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Peter Maydell, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Paolo Bonzini, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Anthony Liguori, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Eric Blake, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Anthony Liguori, 2012/06/06
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time, Anthony Liguori, 2012/06/07
[Qemu-devel] [PATCH v2 09/25] build: put qom/ rules in a Makefile.objs file, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 21/25] build: move device tree to per-target Makefile, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 04/25] build: move *-user/ objects to nested Makefile.objs, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 19/25] build: convert libhw to nested Makefile.objs, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 08/25] build: move rules for nesting to Makefile.objs, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 03/25] build: add rules for nesting, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 13/25] build: move ui/ objects to nested Makefile.objs, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 07/25] build: move other target-*/ objects to nested Makefile.objs, Paolo Bonzini, 2012/06/06
[Qemu-devel] [PATCH v2 02/25] build: do not sprinkle around GENERATED_HEADERS dependencies, Paolo Bonzini, 2012/06/06