Re: [Qemu-devel] [PATCH v3 0/4] Standard SD host controller model

[Igor Mitsyanko]

On 06/07/2012 04:24 PM, Andreas Färber wrote:
> Am 07.06.2012 07:05, schrieb Peter A. G. Crosthwaite:
> > [Original cover by Igor]
> > First patch introduces standard SD host controller model. This is accumulated
> > version of my previous patch I sent a while ago and a recent SDHCI patch by
> > Peter A. G. Crosthwaite.
> > Second patch introduces Exynos4210-specific SDHCI built on top of standard SDHCI
> > model.
> >
> > [New]
> > Third patch changes the -sd command line argument to be repeatable, to support 
> > multiple SD controllers in one system.
> > Fourth patch adds 2x SDHCI controllers to the Xilinx Zynq machine
> It's good to see agreement finally being reached here. Looking forward
> to testing it on my tegra branch. Vincent's version claimed compliance
> to version 3.00 while this one says 2.00. What's the delta then, Igor?
>
> http://git.chromium.org/gitweb/?p=chromiumos/third_party/qemu.git;a=commit;h=9b9c2ea8bd25be06b23a30f07262ade9190d8e95
Looks like its not actually true, the first thing I noticed is that 
documentation defines mandatory 3.00 controller registers Host Control 2 
and Preset Values, which Vincent's version doesn't implement, I'd say 
that his version complies with 2.00 spec. Version sent by Peter 
implements a wider set of SD host controller features comparing to 
Vincen't version.
> I'm guessing I at least still need to cherry-pick Vincent's eMMC support
> bits on top since hw/sd.c and hw/blockdev.c are unmodified in this series.
>
> I'm cc'ing Kevin as block maintainer (PMM is on vacation). I'm hoping
> the typos in the commit messages can be fixed when applying to either
> branch.
>
> Regards,
> Andreas
>
> > Changelog:
> > Changed from v2:
> > corrected typo errors in ADMA1 support
> > added patches 3-4
> > v1->v2
> >   PATCH1:
> >    add support for ADMA1 (I havn't tested it though).
> >    fixed s->prnsts<->  s->pwrcon typo (thanks to Peter, strange that it even 
> > worked
> >    before).
> >   PATCH2:
> >    change header prefix from "target-arm" to "exynos4210".
> >
> > Igor Mitsyanko (2):
> >    hw: introduce standard SD host controller
> >    exynos4210: introduce Exynos4210 SD host controller model
> >
> > Peter A. G. Crosthwaite (2):
> >    vl.c: allow for reapeated -sd arguments
> >    xilinx_zynq: Added sdhci controllers
> >
> >   Makefile.objs                   |    1 +
> >   Makefile.target                 |    1 +
> >   default-configs/arm-softmmu.mak |    1 +
> >   hw/exynos4210.c                 |   20 +
> >   hw/exynos4210_sdhci.c           |  438 +++++++++++++
> >   hw/sdhci.c                      | 1306 +++++++++++++++++++++++++++++++++++++++
> >   hw/sdhci.h                      |  310 +++++++++
> >   hw/xilinx_zynq.c                |   12 +
> >   vl.c                            |    2 +-
> >   9 files changed, 2090 insertions(+), 1 deletions(-)
> >   create mode 100644 hw/exynos4210_sdhci.c
> >   create mode 100644 hw/sdhci.c
> >   create mode 100644 hw/sdhci.h