qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 06/29] build: move libobj-y variable to neste

From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v3 06/29] build: move libobj-y variable to nested Makefile.objs
Date: Fri, 08 Jun 2012 10:03:11 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 
Am 08.06.2012 01:18, schrieb Paolo Bonzini:
> Il 07/06/2012 23:10, Blue Swirl ha scritto:
>>> diff --git a/target-sparc/Makefile.objs b/target-sparc/Makefile.objs
>>> index c574c9e..3556d13 100644
>>> --- a/target-sparc/Makefile.objs
>>> +++ b/target-sparc/Makefile.objs
>>> @@ -1 +1,7 @@
>>> -# still empty
>>> +obj-y += helper.o cpu.o
>>> +obj-y += fop_helper.o cc_helper.o win_helper.o mmu_helper.o ldst_helper.o
>>> +obj-$(TARGET_SPARC) += int32_helper.o
>>> +obj-$(TARGET_SPARC64) += int64_helper.o
>>> +obj-$(TARGET_SPARC64) += vis_helper.o
>>> +
>>> +$(obj)/op_helper.o: QEMU_CFLAGS += $(HELPER_CFLAGS)
>>
>> Please remove.
> 
> Fixed, updated branch to commit 067ca6b.  Thanks.

Anthony, are you planning to pull this soon? This refactoring is
blocking even the first batch of qom-next patches and any other series
that touches Makefiles.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
reply via email to
[Prev in Thread] Current Thread [Next in Thread]