Re: [Qemu-devel] [PATCH v4 0/7] trace: Generic event state description

[Stefan Hajnoczi]

On Tue, May 8, 2012 at 3:38 PM, Lluís Vilanova <address@hidden> wrote:
> Provides a generic event state description and a more detailed event control 
> and
> query interface.
>
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
>
> Changes in v4:
>
> * Documentation fixes and (re)formatting.
>
> Changes in v3:
>
> * Add some assertions.
>
> * Remove debugging printf's.
>
> * Improve documentation.
>
> * Make 'trace_event_get_state_static' use run-time information, and leave
>  TRACE_*_ENABLED for compile-time checks.
>
>
> Changes in v2:
>
> * Minor compilation fixes.
>
>
> Lluís Vilanova (7):
>      tracetool: Explicitly identify public backends
>      trace: Provide a generic tracing event descriptor
>      trace: Provide a detailed event control interface
>      trace: [monitor] Use new event control interface
>      trace: [default] Use new event control interface
>      trace: [simple] Port to generic event information and new control 
> interface
>      trace: [stderr] Port to generic event information and new control 
> interface
>
>
>  Makefile                              |    5 +
>  Makefile.objs                         |   21 ++++
>  docs/tracing.txt                      |   42 +++----
>  monitor.c                             |   15 ++-
>  scripts/tracetool.py                  |    4 -
>  scripts/tracetool/backend/__init__.py |   16 +++
>  scripts/tracetool/backend/dtrace.py   |    3 +
>  scripts/tracetool/backend/events.py   |   23 ++++
>  scripts/tracetool/backend/simple.py   |   15 +--
>  scripts/tracetool/backend/stderr.py   |   28 ++---
>  scripts/tracetool/backend/ust.py      |    3 +
>  scripts/tracetool/format/events_c.py  |   39 +++++++
>  scripts/tracetool/format/events_h.py  |   50 +++++++++
>  scripts/tracetool/format/h.py         |    9 --
>  trace/control-internal.h              |   60 +++++++++++
>  trace/control.c                       |   92 +++++++++++++++-
>  trace/control.h                       |  185 
> ++++++++++++++++++++++++++++++---
>  trace/default.c                       |    6 +
>  trace/event-internal.h                |   33 ++++++
>  trace/simple.c                        |   37 ++-----
>  trace/simple.h                        |    6 -
>  trace/stderr.c                        |   35 +-----
>  trace/stderr.h                        |   11 --
>  23 files changed, 568 insertions(+), 170 deletions(-)
>  create mode 100644 scripts/tracetool/backend/events.py
>  create mode 100644 scripts/tracetool/format/events_c.py
>  create mode 100644 scripts/tracetool/format/events_h.py
>  create mode 100644 trace/control-internal.h
>  create mode 100644 trace/event-internal.h
>  delete mode 100644 trace/stderr.h

What is the point of sstate vs dstate?  It seems the dynamic state is
what can be toggled and sstate is the "disable" keyword.  Why have
sstate since there is already a macro?

Stefan