Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

[Alexander Graf]

On 12.06.2012, at 12:07, Christian Borntraeger <address@hidden> wrote:

> On 12/06/12 11:58, Alexander Graf wrote:
>> Jens Freimann wrote:
>>> From: Christian Borntraeger <address@hidden>
>>> 
>>> The sclp facility on s390 is a hardware that is external to the cpu.
>>> Lets cleanup the definitions and move the functionality into a separate
>>> file under hw/.
>>> 
>> 
>> Phew. I'm not sure this is a great idea. At least not the way the code
>> is structured now. Andreas, do you have any idea how to get this done
>> nicely? We'd have to invent our own bus to communicate to the device,
>> right? And then also actually spawn one.
> 
> There are followup patches which add qom etc see patch 6. Can you look at
> the end result?

Btw, the fact that this is a preparation step for more rework later is a pretty 
crucial part of the patch description :).

Alex