[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MIPS: Correct MIPS16/microMIPS branch size calc
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] MIPS: Correct MIPS16/microMIPS branch size calculation |
|
Date: |
Tue, 12 Jun 2012 08:01:27 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 2012-06-07 18:06, Maciej W. Rozycki wrote:
> "Use MIPS_HFLAG_B16 to determine the address of a jump instruction when we
> need to restart a delay slot instruction."
>
> and was not accompanied by a test case nor I have one offhand.
>
> However this change appears obviously correct to me, and the same
> calculation is already used in exception_resume_pc applied to ordinary,
> Debug and NMI exceptions. This code on the other hand applies to reset
> exceptions and instruction restarts in the context of I/O.
Reviewed-by: Richard Henderson <address@hidden>
r~