[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal f
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function" |
Date: |
Wed, 13 Jun 2012 14:22:57 +0300 |
On Wed, Jun 13, 2012 at 01:15:23PM +0200, Jan Kiszka wrote:
> On 2012-06-12 17:15, Michael S. Tsirkin wrote:
> > On Tue, Jun 12, 2012 at 04:05:19PM +0100, Anthony PERARD wrote:
> >> This reverts commit 94a09e2c846374a96719cda2b4e1312d8c4b08a7.
> >>
> >> This function is used by a later patch to parse the BDF of the device to
> >> passthrough.
> >>
> >> Signed-off-by: Anthony PERARD <address@hidden>
> >
> > You probably want to parse the host address? You don't want to copy the
> > bugs in pci_parse_devaddr - write your own that has sane semantics
> > for host. E.g. you need to support ARI etc.
>
> We should really consolidate over one parser for Xen, KVM device
> assignment and VFIO. It looks like they all have very similar requirements.
Also rename pci_parse_devaddr to pci_parse_legacy_devaddr
to stress it's not something others should reuse.
> For those how didn't follow the discussion, see patches 10-13 in
> http://thread.gmane.org/gmane.comp.emulators.qemu/153728.
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT T DE IT 1
> Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH V12 0/9] Xen PCI Passthrough, Anthony PERARD, 2012/06/12
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Stefano Stabellini, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Andreas Färber, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Anthony PERARD, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/13
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Anthony PERARD, 2012/06/14
- Re: [Qemu-devel] [PATCH V12 5/9] Revert "pci: don't export an internal function", Jan Kiszka, 2012/06/14