[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert |
Date: |
Thu, 14 Jun 2012 12:51:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
Am 13.06.2012 16:36, schrieb Dong Xu Wang:
> add-cow file can't live alone, must together will image_file and backing_file.
> If we implement qemu-img convert operation for add-cow file format, we must
> create image_file and backing_file manually, that will be confused for users,
> so we just ignore add-cow format while doing converting.
>
> Signed-off-by: Dong Xu Wang <address@hidden>
NACK.
This stupid "let's drop the feature, it might confuse users" attitude is
known from Gnome, but not from qemu.
There's no technical reason to forbid it and anyone who manages to
create a valid add-cow image will also be able to specify the very same
options to a convert command. Also, having image format specific code in
qemu-img is evil.
Kevin
- [Qemu-devel] [PATCH 1/6 v10] docs: spec for add-cow file format, Dong Xu Wang, 2012/06/13
- [Qemu-devel] [PATCH 2/6] block: make some functions public, Dong Xu Wang, 2012/06/13
- [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert, Dong Xu Wang, 2012/06/13
- Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert, Dong Xu Wang, 2012/06/14
- Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert, Kevin Wolf, 2012/06/14
- Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert, Dong Xu Wang, 2012/06/14
- Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert, Kevin Wolf, 2012/06/14
- Re: [Qemu-devel] [PATCH 4/6] qemu-img: add-cow will not support convert, Dong Xu Wang, 2012/06/14
[Qemu-devel] [PATCH 3/6] add-cow file format, Dong Xu Wang, 2012/06/13
[Qemu-devel] [PATCH 6/6] add-cow: support qemu-iotests, Dong Xu Wang, 2012/06/13
[Qemu-devel] [PATCH 5/6] add-cow: support snapshot_blkdev, Dong Xu Wang, 2012/06/13