[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Does kvm_fd mean KVM or VCPU fd?
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] Does kvm_fd mean KVM or VCPU fd? |
|
Date: |
Thu, 14 Jun 2012 16:49:37 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 14.06.2012 12:16, schrieb 陳韋任 (Wei-Ren Chen):
>>> I think KVM_CREATE_VCPU should return VCPU fd, right? AFAIK, in KVM
>>> world, kvm_fd usually means the fd we get after opening "/dev/kvm".
>>> Just want to make sure I understand the code correcly. Thanks.
>>
>> This is the kvm_fd inside struct CPUState, so it's per-CPU.
>
> Okay, then it's VCPU fd. Don't know rename it or add a comment to indicate
> it's a VCPU fd is a good idea. ;)
Not a good idea, those fields need to move from CPU*State to CPUState.
We can rename them then if someone has a good suggestion.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg