Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build

[Edgar E. Iglesias]

On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas Färber wrote:
> Hello Edgar and Peter,
> 
> With the Makefile refactoring applied now, here's the Makefile improvements
> for MicroBlaze I mentioned.
> 
> All Xilinx devices that are used for more than one softmmu are compiled once
> in libhw32. Actually some also in libhw64 due to ppc440 being compiled into
> ppc64, but we can fix that in a second step via Alex' ppc-next, we're already
> down from thrice to twice.
> 
> The middle patch is extracted from Blue's logging refactoring.
> 
> Please test and apply. Your s3adp1800 and virtel_ml507 test images complain
> both with and without patches about not finding "eth0". Selftest completes ok
> except for not finding /usr/bin/sha1test on ppc440.
> 
> xilinx_ethlite.c uses tswap32(). Have you ever tested this device to work on
> microblazeel? I wonder if we could change the device from DEVICE_NATIVE_ENDIAN
> to DEVICE_BIG_ENDIAN and in place of tswap32() use a bswap32() conditional on
> HOST_WORDS_BIGENDIAN so that it becomes independent of the target, too?
> 
> Instead of adding random devices to hw/microblaze/Makefile.objs in new series,
> they should be added to hw/Makefile.objs with appropriate CONFIG_* options set
> in default-configs/microblaze[el]-softmmu.mak as demonstrated here, easy to do
> and also ensures that the appropriate poisoning is applied.

Applied the series, thanks Andreas.


> 
> Regards,
> Andreas
> 
> Cc: Edgar E. Iglesias <address@hidden>
> Cc: Peter A. G. Crosthwaite <address@hidden>
> Cc: Alexander Graf <address@hidden>
> Cc: Blue Swirl <address@hidden>
> 
> Andreas Färber (3):
>   hw/xilinx_*: Share Xilinx devices between ppc and microblaze
>   qemu-log: Allow usage in libhw
>   xilinx_axi*: Share devices between microblaze and microblazeel
> 
>  default-configs/microblaze-softmmu.mak   |    2 ++
>  default-configs/microblazeel-softmmu.mak |    2 ++
>  default-configs/ppc-softmmu.mak          |    1 +
>  default-configs/ppc64-softmmu.mak        |    1 +
>  default-configs/ppcemb-softmmu.mak       |    1 +
>  hw/Makefile.objs                         |    7 +++++++
>  hw/microblaze/Makefile.objs              |    5 -----
>  hw/ppc/Makefile.objs                     |    3 ---
>  qemu-log.h                               |    2 ++
>  9 files changed, 16 insertions(+), 8 deletions(-)
> 
> -- 
> 1.7.7
>