[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_err
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error |
Date: |
Fri, 15 Jun 2012 15:12:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 06/15/2012 09:05 AM, Paolo Bonzini wrote:
> (Mostly untested).
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/mirror.c | 50 +++++++++++++++++++++++++++++++++++++++++---------
> block_int.h | 4 ++++
> blockdev.c | 14 ++++++++++++--
> hmp.c | 3 ++-
> qapi-schema.json | 7 ++++++-
> qmp-commands.hx | 8 +++++++-
> 6 files changed, 72 insertions(+), 14 deletions(-)
> +++ b/qapi-schema.json
> @@ -1379,6 +1379,10 @@
> # (all the disk, only the sectors allocated in the topmost image, or
> # only new I/O).
> #
> +# @on_source_error: #optional the action to take on an error on the source
> +#
> +# @on_target_error: #optional the action to take on an error on the target
Mention the default when not provided.
> +#
> # Returns: nothing on success
> # If @device is not a valid block device, DeviceNotFound
> # If @target can't be opened, OpenFileFailed
> @@ -1389,7 +1393,8 @@
> { 'command': 'drive-mirror',
> 'data': { 'device': 'str', 'target': 'str', '*format': 'str',
> 'sync': 'MirrorSyncMode', '*mode': 'NewImageMode',
> - '*speed': 'int' } }
> + '*speed': 'int', '*on_source_error': 'BlockdevOnError',
> + '*on_target_error': 'BlockdevOnError' } }
QMP should prefer - over _; shouldn't this be '*on-source-error' and
'*on-target-error'?
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH 11/36] block: reorganize io error code, (continued)
- [Qemu-devel] [RFC PATCH 11/36] block: reorganize io error code, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 15/36] qemu-iotests: add tests for streaming error handling, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 13/36] block: introduce block job error, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 20/36] block: forward bdrv_iostatus_reset to block job, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 21/36] block: introduce new dirty bitmap functionality, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 22/36] block: add mirror job, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 19/36] block: add target info to QMP query-blockjobs command, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error, Paolo Bonzini, 2012/06/15
- Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error,
Eric Blake <=
- [Qemu-devel] [RFC PATCH 24/36] mirror: support querying target file, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 29/36] mirror: implement completion, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 34/36] block: return count of dirty sectors, not chunks, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 33/36] mirror: perform COW if the cluster size is bigger than the granularity, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 26/36] block: live snapshot documentation tweaks, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 35/36] block: allow customizing the granularity of the dirty bitmap, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 36/36] mirror: allow customizing the granularity, Paolo Bonzini, 2012/06/15
- [Qemu-devel] [RFC PATCH 17/36] block: add bdrv_query_stats, Paolo Bonzini, 2012/06/15