qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qemu_agent: Wait for events inste


From: Michal Privoznik
Subject: Re: [Qemu-devel] [libvirt] [PATCH 2/2] qemu_agent: Wait for events instead of agent response
Date: Sat, 16 Jun 2012 09:51:35 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120608 Thunderbird/13.0

On 15.06.2012 19:16, Eric Blake wrote:
> On 06/15/2012 10:10 AM, Michal Privoznik wrote:
>> With latest changes to qemu-ga success on some commands is not reported
>> anymore, e.g. guest-shutdown or guest-suspend-*. However, errors are
>> still being reported. Therefore, we need to find different source of
>> indication if operation was successful. Events.
>> ---
>>  src/qemu/qemu_agent.c   |   49 
>> ++++++++++++++++++++++++++++++++++++++++++----
>>  src/qemu/qemu_agent.h   |    9 ++++++++
>>  src/qemu/qemu_process.c |    7 ++++++
>>  3 files changed, 60 insertions(+), 5 deletions(-)
>>
> 
>> @@ -1238,6 +1257,24 @@ error:
>>      return NULL;
>>  }
>>  
>> +void qemuAgentNotifyEvent(qemuAgentPtr mon,
>> +                          qemuAgentEvent event)
>> +{
>> +    VIR_DEBUG("mon=%p event=%d", mon, event);
>> +    if (mon->await_event == event) {
>> +        VIR_DEBUG("Wakening up a tragedian");
> 
> s/Wakening/Waking/
> 
> ACK.
> 
> 

Fixed and pushed. Thanks.

Michal




reply via email to

[Prev in Thread] Current Thread [Next in Thread]