[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kerne
From: |
Guan Xuetao |
Subject: |
Re: [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kernel can access user space |
Date: |
Mon, 18 Jun 2012 10:03:33 +0800 |
On Fri, 2012-06-15 at 18:01 +0800, 陳韋任 (Wei-Ren Chen) wrote:
> Hi Guan,
>
> > /* These instructions trap after executing, so defer them until after the
> > conditional executions state has been updated. */
> > @@ -1551,12 +1558,12 @@ static void do_misc(CPUUniCore32State *env,
> > DisasContext *s, uint32_t insn)
> > /* load/store I_offset and R_offset */
> > static void do_ldst_ir(CPUUniCore32State *env, DisasContext *s, uint32_t
> > insn)
> > {
> > - unsigned int i;
> > + unsigned int mmuindex;
> ^^^^^^^^
> I would suggest you to rename it to mmu_idx or something like that. :)
>
> Regards,
> chenwj
>
Done, thx.
Regards
Guan Xuetao
- [Qemu-devel] [PATCHv2 04/13] unicore32-softmmu: Implement softmmu specific functions, (continued)
- [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kernel can access user space, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 09/13] unicore32-softmmu: Add puv3 gpio support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 10/13] unicore32-softmmu: Add puv3 pm support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 07/13] unicore32-softmmu: Add puv3 interrupt support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 13/13] unicore32-softmmu: Add maintainer information for UniCore32 machine, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 11/13] unicore32-softmmu: Add puv3 dma support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 06/13] unicore32-softmmu: Add puv3 soc/board support, Guan Xuetao, 2012/06/15
- [Qemu-devel] [PATCHv2 12/13] unicore32-softmmu: Add ps2 support, Guan Xuetao, 2012/06/15
- Re: [Qemu-devel] [PATCHv2 00/13] unicore32: add softmmu support and puv3 machine, Wei-Ren Chen, 2012/06/15