qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kerne


From: Guan Xuetao
Subject: Re: [Qemu-devel] [PATCHv2 05/13] unicore32-softmmu: Make sure that kernel can access user space
Date: Mon, 18 Jun 2012 10:03:33 +0800

On Fri, 2012-06-15 at 18:01 +0800, 陳韋任 (Wei-Ren Chen) wrote:
> Hi Guan,
> 
> >  /* These instructions trap after executing, so defer them until after the
> >     conditional executions state has been updated.  */
> > @@ -1551,12 +1558,12 @@ static void do_misc(CPUUniCore32State *env, 
> > DisasContext *s, uint32_t insn)
> >  /* load/store I_offset and R_offset */
> >  static void do_ldst_ir(CPUUniCore32State *env, DisasContext *s, uint32_t 
> > insn)
> >  {
> > -    unsigned int i;
> > +    unsigned int mmuindex;
>                     ^^^^^^^^
>    I would suggest you to rename it to mmu_idx or something like that. :)
> 
> Regards,
> chenwj
> 
Done, thx.

Regards

Guan Xuetao




reply via email to

[Prev in Thread] Current Thread [Next in Thread]