Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

[Andreas Färber]

Am 18.06.2012 11:31, schrieb Peter Maydell:
> On 18 June 2012 10:13, Jan Kiszka <address@hidden> wrote:
>> On 2012-06-18 02:32, Andreas Färber wrote:
>>> This will work technically but I still feel this is wrong semantically.
>>> The pre-Paolo and current way is picking specific files from the hw/kvm/
>>> directory. Your change above implies that in hw/kvm/ only x86 files can
>>> live, which I dislike.
> 
>> Some per-arch separation is required, at least in the build process.
>> We'll see power and arm stubs for in-kernel devices soon.
> 
> Indeed -- I have a hw/kvm/arm_gic.c in the qemu-linaro tree, so
> if you break building that I'll have to unbreak it :-)
> 
> (Does architecture-specific separation make much sense in general?
> Not all devices are architecture-specific. I'd have thought that
> a functional split eg timer/serial/usb like the linux kernel layout
> would be better.)

Maybe you're misreading me? I was saying iff a device is specifically
(not accidentally) for one target foo then it may/should be placed into
hw/foo/ directory.

We already have a hw/usb/ directory, and as long as there are no target
dependencies and sufficient files I see nothing wrong with hw/timer/ or
hw/serial/.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg