[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-h
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH buildfix] configure: Assure existence of linux-headers/ build directory |
Date: |
Tue, 19 Jun 2012 16:18:51 +0100 |
On 14 June 2012 16:14, Andreas Färber <address@hidden> wrote:
> Commit ec5b06d (configure: ensure directory exists when creating symlinks)
> moved the creation of directories into the symlink() function but forgot
> the case where no symlink is created.
>
> This leads to build errors on arm Linux due to -I../linux-headers.
>
> Unbreak the build on arm Linux by reverting part of that commit.
I think it would be better to just revert ec5b06d completely.
The comment documenting the symlink() function says
"# symbolically link $1 to $2. Portable version of "ln -sf"
and "ln -sf" doesn't create the target directory, so symlink()
should not either.
-- PMM