Re: [Qemu-devel] [PATCH v12 01/13] Add MigrationParams structure

[Orit Wasserman]

On 06/19/2012 07:00 PM, Eric Blake wrote:
> On 06/19/2012 09:43 AM, Orit Wasserman wrote:
>> From: Isaku Yamahata <address@hidden>
>>
>> Signed-off-by: Isaku Yamahata <address@hidden>
>> ---
> 
>>  
>> -static void block_set_params(int blk_enable, int shared_base, void *opaque)
>> +static void block_set_params(const MigrationParams *params, void *opaque)
> 
> As long as we are changing this signature...
> 
>> @@ -394,9 +393,13 @@ void qmp_migrate(const char *uri, bool has_blk, bool 
>> blk,
>>                   Error **errp)
>>  {
>>      MigrationState *s = migrate_get_current();
>> +    MigrationParams params;
>>      const char *p;
>>      int ret;
>>  
>> +    params.blk = blk;
> 
> ...and since blk is only ever a bool to begin with...
> 
>>  
>> +struct MigrationParams {
>> +    int blk;
>> +    int shared;
> 
> ...why not use bool instead of int in this struct to represent the fact
> that it really is a binary choice?  I think the same can be said for shared.
you right , I will fix it.

Orit
>