Re: [Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support

[Guan Xuetao]

On Mon, 2012-06-18 at 20:05 +0000, Blue Swirl wrote:
[snip]
> > +static void puv3_pm_write(void *opaque, target_phys_addr_t offset,
> > +        uint64_t value, unsigned size)
> > +{
> > +    PUV3PMState *s = (PUV3PMState *) opaque;
> > +
> > +    switch (offset) {
> > +    case 0x0:
> > +        s->reg_PMCR = value;
> 
> Missing 'break' or a comment about fall through.
Yes, 'break' is missed here.
Thanks ever so much.

Guan Xuetao