qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions


From: Benjamin Herrenschmidt
Subject: Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions
Date: Sun, 24 Jun 2012 17:28:43 +1000

On Sun, 2012-06-24 at 06:03 +0000, Blue Swirl wrote:
> > +     * A smarter implementation can be devised if needed to
> > +     * use lighter barriers based on the direction of the
> > +     * transfer, the DMA context, etc...
> > +     */
> > +    if (kvm_enabled())
> > +        smp_mb();
> 
> Missing braces. Please use checkpatch.pl to avoid issues like this.

Ooops, sorry, forgot to make my code butt-ugly ...

I generally run checkpatch lately, for some reason this one went through
the cracks.

Anthony, do you need a repost or can you fix it up ?

Cheers,
Ben.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]