[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions |
Date: |
Sun, 24 Jun 2012 17:28:43 +1000 |
On Sun, 2012-06-24 at 06:03 +0000, Blue Swirl wrote:
> > + * A smarter implementation can be devised if needed to
> > + * use lighter barriers based on the direction of the
> > + * transfer, the DMA context, etc...
> > + */
> > + if (kvm_enabled())
> > + smp_mb();
>
> Missing braces. Please use checkpatch.pl to avoid issues like this.
Ooops, sorry, forgot to make my code butt-ugly ...
I generally run checkpatch lately, for some reason this one went through
the cracks.
Anthony, do you need a repost or can you fix it up ?
Cheers,
Ben.
- [Qemu-devel] [PATCH 00/11] iommu series, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 01/11] Better support for dma_addr_t variables, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 03/11] usb-ohci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 04/11] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 02/11] iommu: Add universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 06/11] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 05/11] ide/ahci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 11/11] Add a memory barrier to DMA functions, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 07/11] iommu: Introduce IOMMU emulation infrastructure, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 10/11] pseries: Implement IOMMU and DMA for PAPR PCI devices, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 09/11] iommu: Allow PCI to use IOMMU infrastructure, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 08/11] pseries: Convert sPAPR TCEs to use generic IOMMU infrastructure, Benjamin Herrenschmidt, 2012/06/21
- [Qemu-devel] [PATCH 00/11] iommu series, Benjamin Herrenschmidt, 2012/06/27
- [Qemu-devel] [PATCH 01/11] Better support for dma_addr_t variables, Benjamin Herrenschmidt, 2012/06/27
- [Qemu-devel] [PATCH 03/11] usb-ohci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/27
- [Qemu-devel] [PATCH 04/11] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers, Benjamin Herrenschmidt, 2012/06/27
- [Qemu-devel] [PATCH 06/11] usb: Convert usb_packet_{map, unmap} to universal DMA helpers, Benjamin Herrenschmidt, 2012/06/27
- [Qemu-devel] [PATCH 05/11] ide/ahci: Use universal DMA helper functions, Benjamin Herrenschmidt, 2012/06/27