Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t

[Peter Maydell]

On 25 June 2012 14:48, Andreas Färber <address@hidden> wrote:
> Am 25.06.2012 14:45, schrieb Peter Maydell:
>> This patchset defines a set of macros for use in printf format strings
>> for handling target_phys_addr_t values, as suggested by Andreas Färber
>> (http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01547.html)
>
> What is the X for again? I assume PL = Physical Long, X as in
> hexadecimal would then contradict the d/u and duplicate x/X.

I'm just following the existing use of 'plx' in TARGET_FMT_plx,
but I'm not very attached to the abbreviation.

> Thus I would suggest TARGET_PRIdPHYSADDR, also addressing Eric's
> comment. Judging from patches 2-4 it's not used to frequently unlike its
> user TARGET_FMT_plx, so we don't have to badly shorten it for usability.

The hope is that it is used more extensively in the future (ie
any device that would have used TARGET_FMT_plx should use these
instead); I think TARGET_PRIdPHYSADDR is too long.

-- PMM