[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM object
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line |
Date: |
Tue, 26 Jun 2012 16:00:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 26.06.2012 15:35, schrieb Anthony Liguori:
> On 06/26/2012 03:42 AM, Markus Armbruster wrote:
>> Anthony Liguori<address@hidden> writes:
>>
>>> This will create a new QOM object in the '/objects' path. Note that
>>> properties
>>
>> Long line, will look fugly in git-log. Please wrap at column 70-75.
>
> Okay, let me turn this around:
>
> How do people normally limit this beyond just eye-balling? My terminals
> are 80-width as god intended them to be. Trying to guess whether you
> cross 75 or not seems to be a bit silly. git also doesn't do anything
> helpful like stick an indicator in the comments below the message where
> the 75 character mark is.
nano does some magic for breaking the lines, not sure where exactly. I
used that on some of the qom-next patches I picked up.
What I usually check after committing is the mentioned `git log`, that
adds an extra four spaces, i.e. 76 characters in an 80-width terminal
(allowing for ~three quote levels).
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 0/4] qdev realize, -object, and -object-late, Anthony Liguori, 2012/06/25
- [Qemu-devel] [PATCH 1/4] object: add object_property_add_bool (v2), Anthony Liguori, 2012/06/25
- [Qemu-devel] [PATCH 2/4] qdev: add realized property and make adding child bus implied by realize, Anthony Liguori, 2012/06/25
- [Qemu-devel] [PATCH 4/4] vl: add -late-object to create QOM objects after machine init, Anthony Liguori, 2012/06/25
- [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line, Anthony Liguori, 2012/06/25
- Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line, Blue Swirl, 2012/06/26
- Re: [Qemu-devel] [PATCH 0/4] qdev realize, -object, and -object-late, Markus Armbruster, 2012/06/26