qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM object


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 3/4] vl: add -object option to create QOM objects from the command line
Date: Tue, 26 Jun 2012 16:00:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0

Am 26.06.2012 15:35, schrieb Anthony Liguori:
> On 06/26/2012 03:42 AM, Markus Armbruster wrote:
>> Anthony Liguori<address@hidden>  writes:
>>
>>> This will create a new QOM object in the '/objects' path.  Note that
>>> properties
>>
>> Long line, will look fugly in git-log.  Please wrap at column 70-75.
> 
> Okay, let me turn this around:
> 
> How do people normally limit this beyond just eye-balling?  My terminals
> are 80-width as god intended them to be.  Trying to guess whether you
> cross 75 or not seems to be a bit silly.  git also doesn't do anything
> helpful like stick an indicator in the comments below the message where
> the 75 character mark is.

nano does some magic for breaking the lines, not sure where exactly. I
used that on some of the qom-next patches I picked up.

What I usually check after committing is the mentioned `git log`, that
adds an extra four spaces, i.e. 76 characters in an 80-width terminal
(allowing for ~three quote levels).

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]