Re: [Qemu-devel] [PATCH v2] bitops.h: Add field32() and field64() functions to extract bitfields

[Markus Armbruster]

Avi Kivity <address@hidden> writes:

> On 06/27/2012 04:28 PM, Eric Blake wrote:
[...]
>> You marked this function signature as returning uint64_t, but didn't
>> return anything.  I think the logical return is the new contents of
>> *pvalue.  Another logical choice would be marking the function void.
>> 
>
> Void makes more sense here as you usually want in-place update.

It's an assignment, so I'd follow the precedence of C's assignment
operator and return the new value of the left hand side.