Re: [Qemu-devel] [PATCH v13 02/13] Add migration capabilites

[Eric Blake]

On 06/27/2012 04:34 AM, Orit Wasserman wrote:
> Add migration capabilites that can be queried by the management.

s/capabilites/capabilities/

> The management can query the source QEMU and the destination QEMU in order to
> verify both support some migration capability (currently only XBZRLE).
> The managment can enable a capability for the next migration by using

s/managment/management/

> migrate_set_parameter command.
> 
> Signed-off-by: Orit Wasserman <address@hidden>

> +++ b/qapi-schema.json
> @@ -286,7 +286,7 @@
>  ##
>  { 'type': 'MigrationInfo',
>    'data': {'*status': 'str', '*ram': 'MigrationStats',
> -           '*disk': 'MigrationStats'} }
> +           '*disk': 'MigrationStats', '*params': 
> ['MigrationCapabilityInfo']} }

'params' is an abbreviation, and QMP tends to avoid those.  Furthermore,
I think it might be better naming this array '*capabilities' instead of
'*params'.

>  ##
> +# @MigrationCapability
> +#
> +# Migration capabilities enumaration

s/enumaration/enumeration/


> +# Set the following migration parameters (like xbzrle)
> +##
> +# Since: 1.2
> +##
> +{ 'command': 'migrate-set-parameters', 'data': { 'parameters': 
> ['MigrationCapabilityInfo'] } }

Here, you at least spelled it out as 'parameters' instead of 'params',
but I still think 'capabilities' would be a more consistent name for the
array.

> +SQMP
> +migrate_set_parameters
> +-------
> +
> +Enable migration capabilities

Thanks to the state portion of each MigrationCapabilityInfo, this
command can actually enable _or disable_ migration capabilities.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature