Re: [Qemu-devel] [PATCH v13 13/13] Add XBZRLE statistics

[Eric Blake]

On 06/27/2012 04:34 AM, Orit Wasserman wrote:
> Signed-off-by: Benoit Hudzia <address@hidden>
> Signed-off-by: Petter Svard <address@hidden>
> Signed-off-by: Aidan Shribman <address@hidden>
> Signed-off-by: Orit Wasserman <address@hidden>
> ---

> +++ b/qmp-commands.hx
> @@ -2093,18 +2093,28 @@ The main json-object contains the following:
>           - "transferred": amount transferred (json-int)
>           - "remaining": amount remaining (json-int)
>           - "total": total (json-int)
> +      - "duplicate": number of duplicated pages (json-int)
> +      - "normal" : number of normal pages transferred (json-int)

TAB damage.

>  - "disk": only present if "status" is "active" and it is a block migration,
>    it is a json-object with the following disk information (in bytes):
>           - "transferred": amount transferred (json-int)
>           - "remaining": amount remaining (json-int)
>           - "total": total (json-int)
> +- "params": migration capabilites state

s/capabilites/capabilities/


>  1. Before the first migration
> -
>  -> { "execute": "query-migrate" }

Why the spurious whitespace deletion?

> -<- { "return": {} }
> +<- { "return": { "params" : { "xbzrle" : "off" } } }

This should be a json-bool, ie. "xbzrle": false

>  
>  2. Migration is done and has succeeded
>  
> @@ -2122,6 +2132,7 @@ Examples:
>  <- {
>        "return":{
>           "status":"active",
> +         "params" : { "xbzrle" : "off" },

again, this should be 'false', not '"off"'.

>           "ram":{
>              "transferred":123,
>              "remaining":123,
> @@ -2136,6 +2147,7 @@ Examples:
>  <- {
>        "return":{
>           "status":"active",
> +         "params" : { "xbzrle" : "off" },

and again

>           "ram":{
>              "total":1057024,
>              "remaining":1053304,
> @@ -2149,6 +2161,28 @@ Examples:
>        }
>     }
>  
> +5. Migration is being performed and XBZRLE is active:
> +
> +-> { "execute": "query-migrate" }
> +<- {
> +      "return":{
> +         "status":"active",
> +         "params" : { "xbzrle" : "on" },

true rather than "on"

> +         "ram":{
> +            "total":1057024,
> +            "remaining":1053304,
> +            "transferred":3720
> +         },
> +         "cache":{
> +            "cache-size": 1024

Missing a trailing comma

> +            "xbzrle-transferred":20971520,
> +            "xbzrle-pages":2444343,
> +            "xbzrle-cache-miss":2244,
> +            "xbzrle-overflow":34434
> +         }
> +      }
> +   }
> +
>  EQMP
>  
>      {
> 

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature