Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

[Edgar E. Iglesias]

On Thu, Jun 28, 2012 at 02:53:13PM +0200, Andreas Färber wrote:
> Am 16.06.2012 03:11, schrieb Edgar E. Iglesias:
> > On Fri, Jun 15, 2012 at 01:30:17PM +0200, Andreas Färber wrote:
> >> Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite:
> >>> Changed device name to xlnx,axi-dma. This is the exact name of the device 
> >>> in the
> >>> Xilinx EDK development tools.
> >>>
> >>> Signed-off-by: Peter A. G. Crosthwaite <address@hidden>
> >>
> >> Same here. Please review more carefully.
> 
> [referring to: Commit message doesn't match the change. Which one is right?]

...

> Maybe I was a bit brief, not much time for upstream myself lately: I'm

Hi,

Yes me too. I probably missinterpreted your "Please review more carefully"
in a too broad sense and overreacted, sorry.

The name thing came up when Peter wanted to change the names of the devices
to better match xilinx names. I had chosen the names pretty arbitrarily when
adding the devs and figuring they were not really used outside the code, it
seemed OK to change them. I had some vague memory though that the commas
were causing issues with some options, so I asked Peter on the chat to look
at it and that it was probably worth avoiding commas if it caused hassle.

Peter confirmed and changed the names to use dots but I'm guessing forgot
to change the commit msg. When applying the patch, I tested the boards,
they ran and I applied. I didn't look carefully enough at the commit msg.

I've got no problem with chaning to commas if people insist.

Cheers,
Edgar