[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complet
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complete |
Date: |
Fri, 29 Jun 2012 18:27:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Due to queuing/pipelining, there can now be multiple packets per
endpoint in flight. So the assertion in usb_packet_complete became wrong
and can cause bogus QEMU terminations. Seen with a passed-through USB
headset.
Signed-off-by: Jan Kiszka <address@hidden>
---
I'm not 100% sure that the assertion that the assertion is no longer
needed is actually correct. However, things work fine here without it.
hw/usb/core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/usb/core.c b/hw/usb/core.c
index 0e02da7..f4e4bbf 100644
--- a/hw/usb/core.c
+++ b/hw/usb/core.c
@@ -407,7 +407,6 @@ void usb_packet_complete(USBDevice *dev, USBPacket *p)
int ret;
usb_packet_check_state(p, USB_PACKET_ASYNC);
- assert(QTAILQ_FIRST(&ep->queue) == p);
usb_packet_set_state(p, USB_PACKET_COMPLETE);
QTAILQ_REMOVE(&ep->queue, p, queue);
dev->port->ops->complete(dev->port, p);
--
1.7.3.4
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH] usb: Remove obsolete assert from usb_packet_complete,
Jan Kiszka <=