[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] kvm: Don't abort on kvm_irqchip_add_msi_route()
From: |
Marcelo Tosatti |
Subject: |
Re: [Qemu-devel] [PATCH] kvm: Don't abort on kvm_irqchip_add_msi_route() |
Date: |
Fri, 29 Jun 2012 20:02:59 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Jun 25, 2012 at 09:40:39AM -0600, Alex Williamson wrote:
> Anyone using these functions has to be prepared that irqchip
> support may not be present. It shouldn't be up to the core
> code to determine whether this is a fatal error. Currently
> code written as:
>
> virq = kvm_irqchip_add_msi_route(...)
> if (virq < 0) {
> <slow path>
> } else {
> <fast path>
> }
>
> works on x86 with and without kvm irqchip enabled, works
> without kvm support compiled in, but aborts() on !x86 with
> kvm support.
>
> Signed-off-by: Alex Williamson <address@hidden>
Applied to uq/master.