Re: [Qemu-devel] [RFC PATCH 2/3] block: GlusterFS helpers to interface with libglusterfs

[Paolo Bonzini]

Il 19/06/2012 11:31, Bharata B Rao ha scritto:
>>> > > +    ret = pthread_create(&thread, NULL, gluster_handle_poll,
>>> > > +    (void *)gctx);
>> > 
>> > Please use qemu-thread.h.  QEMU uses signals so you almost certainly
>> > want to mask signals for this thread (qemu_thread_create() does that).
> Ok. This is temporary since this entire patch (2/3) would be redundant
> when we have libglusterfsclient working.

Please make sure that libglusterfsclient also masks signals for its own
threads.  It's a pretty common source of bugs with threaded libraries,
and masking the signals is harmless for programs that do not care.

Paolo