Re: [Qemu-devel] [PATCH 3/4] usb: add usb attached scsi emulation

[Gerd Hoffmann]

On 07/01/12 15:36, Paolo Bonzini wrote:
> Il 20/06/2012 14:41, Gerd Hoffmann ha scritto:
>> Special thanks go to Paolo for bringing the qemu scsi emulation into
>> shape, so this can be added nicely without having to touch a single line
>> of scsi code.
> 
> But we can touch it and make it even better. :)
> 
> Do you need a release_req SCSIBusInfo method that is called with the
> hba_private when a request refcount goes to zero, so that you can remove
> usb_uas_ref_request and usb_uas_unref_request?  (and replace it with
> scsi_req_ref/unref in usb_uas_handle_data, I think).

Good idea.  Yes, that would indeed remove the need to do my own
reference counting.

cheers,
  Gerd