[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/12] ram: save_live_setup() we don't need to s
From: |
Orit Wasserman |
Subject: |
Re: [Qemu-devel] [PATCH 12/12] ram: save_live_setup() we don't need to synchronize the dirty bitmap. |
Date: |
Mon, 02 Jul 2012 15:05:13 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
On 06/28/2012 10:22 PM, Juan Quintela wrote:
> 1st: we were synchonizing the dirty bitmap before calling
> memory_global_dirty_log_start().
>
> 2nd: We are marking all pages as dirty anywhere, no reason to go
> through all the bitmap to "mark" dirty same pages twice.
>
> So, call removed.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> arch_init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch_init.c b/arch_init.c
> index 8299c15..c1b4f13 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -308,8 +308,6 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
> ram_addr_t addr;
> RAMBlock *block;
>
> - memory_global_sync_dirty_bitmap(get_system_memory());
> -
> bytes_transferred = 0;
> last_block = NULL;
> last_offset = 0;
>
Reviewed-by: Orit Wasserman <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 12/12] ram: save_live_setup() we don't need to synchronize the dirty bitmap.,
Orit Wasserman <=