Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

[Igor Mitsyanko]

On 07/02/2012 03:44 PM, Andreas Färber wrote:
> Am 01.07.2012 17:26, schrieb Paolo Bonzini:
> > Il 29/06/2012 14:26, Andreas Färber ha scritto:
> > > > > Oh, I see. Should we place this device to hw/Makefile.objs in v2?
> > > That would've been nice, but I'll do it as a follow-up now.
> >
> > Yes, so we can also use Anthony's new CONFIG_ARCH_ARM (introducing
> > CONFIG_EXYNOS can be done later).
>
> I have a patch in the works, but exynos turned out more difficult than
> other devices (also OMAP and PXA2xx) because it uses a shared
> <socname>.h header that uses CPU. For tegra I fixed that by adding an
> #ifdef NEED_CPU_H for the appropriate parts.
>
> Andreas

I think we can drop ARMCPU *cpu[] member from Exynos4210State and just 
use local variable in exynos4210_init() instead, like everyone else does.
exynos4210_write_secondary() prototype can be moved from exynos4210.h 
header to exynos4_boards.c, or we can pass arm_boot_info 
exynos4_board_binfo to Exynos4210 SoC init function exynos4210_init() to 
initialize .write_secondary_boot field there.