qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/4] PPC: e500: rename mpc8544ds into generic fi


From: Scott Wood
Subject: Re: [Qemu-devel] [PATCH 1/4] PPC: e500: rename mpc8544ds into generic file
Date: Mon, 2 Jul 2012 12:06:00 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 07/02/2012 11:50 AM, Andreas Färber wrote:
> Hi Scott,
> 
> Am 28.06.2012 01:50, schrieb Scott Wood:
>> Rename the file (with no changes other than fixing up the header paths)
>> in preparation for refactoring into a generic e500 platform.  Also move
>> it into the newly created ppc/ directory.
>>
>> Signed-off-by: Scott Wood <address@hidden>
>> ---
>>  hw/ppc/Makefile.objs                   |    2 +-
>>  hw/{ppce500_mpc8544ds.c => ppc/e500.c} |   16 ++++++++--------
>>  2 files changed, 9 insertions(+), 9 deletions(-)
>>  rename hw/{ppce500_mpc8544ds.c => ppc/e500.c} (99%)
>>
>> diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs
>> index aa4bbeb..aa77f64 100644
>> --- a/hw/ppc/Makefile.objs
>> +++ b/hw/ppc/Makefile.objs
>> @@ -15,7 +15,7 @@ obj-$(CONFIG_PSERIES) += spapr_pci.o pci-hotplug.o 
>> spapr_iommu.o
>>  obj-y += ppc4xx_devs.o ppc4xx_pci.o ppc405_uc.o ppc405_boards.o
>>  obj-y += ppc440_bamboo.o
>>  # PowerPC E500 boards
>> -obj-$(CONFIG_FDT) += ppce500_mpc8544ds.o mpc8544_guts.o ppce500_spin.o
>> +obj-$(CONFIG_FDT) += ppc/e500.o mpc8544_guts.o ppce500_spin.o
>>  # PowerPC 440 Xilinx ML507 reference board.
>>  obj-y += virtex_ml507.o
>>  # PowerPC OpenPIC
> [snip]
> 
> The location seems perfect for the file and nicely simplifies the file
> name, but could we avoid ../ppc/ by doing:
> 
> obj-$(CONFIG_FDT) += e500.o
> 
> further down after the ../ prefix has been added for the legacy files?

Ah, didn't notice that down there.  Will fix.

-Scott




reply via email to

[Prev in Thread] Current Thread [Next in Thread]