Re: [Qemu-devel] [PATCH] console: Implementing blinking of cursor

[Jan Kiszka]

On 2012-07-03 16:41, Stefan Weil wrote:
> Am 02.07.2012 10:20, schrieb Jan Kiszka:
>> Let the text console cursor blink at 5 HZ.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>> console.c | 26 +++++++++++++++++++++++++-
>> 1 files changed, 25 insertions(+), 1 deletions(-)
>>
> 
> Hi Jan,
> 
> I know that there was a "bug" report. Nevertheless I'd like
> to ask whether QEMU really needs a blinking text cursor.
> 
> Blinking cursors are a matter of taste. I personally don't
> want a blinking cursors. Nor do I want programs which
> wake my cpu 5 times a second for something which I
> don't need.
> 
> It's possible to get a blinking cursor without your patch
> by redirecting QEMU's text console to one of the common
> X terminal emulations (xterm, konsole, ...).
> 
> When QEMU gets GTK support, it might use a terminal
> emulation which allows configurable cursor blinking.
> IMHO that would be better than implementing that feature
> in QEMU code.
> 
> That's why I suggest not to apply the patch.

Well, *if* there should be heavy resistance against this patch, we may
postpone it. But I consider the feature useful to identify the cursor
position and check visually the liveliness of QEMU.

However, the VGA blinking is a feature that should go in, specifically
as there is no impact on wakeups and it fixes an emulation deficit.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux