[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_d
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions |
Date: |
Wed, 04 Jul 2012 05:36:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 07/04/2012 01:24 AM, Orit Wasserman wrote:
>>
>>> + ret = uleb128_decode_small(src + i, &count);
>>> + if (ret < 0) {
>>
>> An nzrun should be a non-zero value; I'd write this as (ret <= 0) to
>> rule out an attempt to pass a zero-length nzrun.
> decode can only return -1 (invalid) or the decoded len 1 or 2
> so maybe you meant I should check that count is bigger than zero?
Yes, and I even corrected myself:
https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00368.html
as well as incorporated my comments (which probably picked up a couple
other fixes in the process):
https://lists.gnu.org/archive/html/qemu-devel/2012-07/msg00369.html
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions, Orit Wasserman, 2012/07/03
Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions, Orit Wasserman, 2012/07/04
Re: [Qemu-devel] [PATCH v14 10/13] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions,
Eric Blake <=
[Qemu-devel] [PATCH v14 05/13] Add uleb encoding/decoding functions, Orit Wasserman, 2012/07/03
[Qemu-devel] [PATCH v14 11/13] Add XBZRLE to ram_save_block and ram_save_live, Orit Wasserman, 2012/07/03
[Qemu-devel] [PATCH v14 02/13] Add migration capabilities, Orit Wasserman, 2012/07/03
[Qemu-devel] [PATCH v14 13/13] Add XBZRLE statistics, Orit Wasserman, 2012/07/03
[Qemu-devel] [PATCH v14 12/13] Add set_cachesize command, Orit Wasserman, 2012/07/03
[Qemu-devel] [PATCH v14 09/13] Add migration_end function, Orit Wasserman, 2012/07/03